Skip to content

Conversation

@shrishrirang
Copy link
Contributor

@shrishrirang shrishrirang commented Dec 23, 2020

  • The 0.3.0 release didn't happen because of "azdev style webapp" errors
  • Incrementing 0.3.0->0.3.1 to kick-off another release

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 23, 2020

webapp

@yungezz
Copy link
Member

yungezz commented Dec 24, 2020

hi @qwordy could you pls give this a quick review?

- The 0.3.0 release didn't happen because of "azdev style webapp" errors
- Incrementing 0.3.0->0.3.1 to kick-off another release
@qwordy
Copy link
Member

qwordy commented Dec 24, 2020

I have not seen any code change. How does it get passed while #2781 fails?
No problem to use 0.3.1. I am OK.

@shrishrirang
Copy link
Contributor Author

shrishrirang commented Dec 24, 2020

The first PR that incremented the version to 0.3.0 was #2768 and it had some style errors.
The second PR #2811 fixed those errors. This PR is just a follow-up PR that bumps up the version from 0.3.0 to 0.3.1, but the actual code changes that fixed the style errors are already merged.

@qwordy
Copy link
Member

qwordy commented Dec 24, 2020

The first PR that incremented the version to 0.3.0 was #2768 and it had some style errors.
The second PR #2811 fixed those errors. This PR is just a follow-up PR that bumps up the version from 0.3.0 to 0.3.1, but the actual code changes that fixed the style errors are already merged.

Got it

@qwordy qwordy merged commit 3f5f62c into Azure:master Dec 24, 2020
@shrishrirang
Copy link
Contributor Author

I don't see a new release triggered for the new version 0.3.1 in this PR. The last PR I see is still for 0.3.0 - #2781. Can you check why is that so and trigger a run manually? Also, #2781 should be closed.

@qwordy
Copy link
Member

qwordy commented Dec 25, 2020

@haroldrandom Can you help have a look? What is the rule to trigger a release PR?

@qwordy
Copy link
Member

qwordy commented Dec 25, 2020

I have closed the old PR 2781

@shrishrirang
Copy link
Contributor Author

@haroldrandom - any idea why this PR didn't release the extension? Can we trigger a manual run of the pipeline if it wasn't automatically triggered for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants