Update connectedmachine extension #2364

TylerLeonhardt · 2020-09-15T03:43:56Z

This updates the connectedmachine extension to 2020-08-02 of the spec. In doing this I also changed the autogenerated tests to test more useful things.

I was told to move the changed tests to the custom folder but after doing that then the test didn't run... so I'm not sure what to do there...

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

add alias for auto_rev_minor_version

azuresdkci · 2020-09-15T03:43:58Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/TylerLeonhardt/azure-cli-extensions.git@sdkAutomation/connectedmachine@10789#subdirectory=src/$EXT&egg=$EXT"

yungezz · 2020-09-15T04:42:12Z

Majority code is generated, less manual written. so LGTM.

TylerLeonhardt · 2020-09-15T05:05:29Z

Yeah the commits tell you what is generated and what is manually edited

src/connectedmachine/README.md

fengzhou-msft · 2020-09-15T07:42:05Z

src/connectedmachine/azext_connectedmachine/generated/_help.py

+    short-summary: "The operation to create or update the extension."
+    examples:
+      - name: Create or Update a Machine Extension


I think we should remove or update here. @qiaozha can we do this in codegen automatically?

Make sense. I filed an issue to track this Azure/autorest.az#553

Suddenly realized the example name is from swagger example reference name. https://github.com/Azure/azure-rest-api-specs/blob/master/specification/hybridcompute/resource-manager/Microsoft.HybridCompute/stable/2020-08-02/HybridCompute.json#L90. Not sure we can change it as we use this to identify the example.
If you mean the short summary I think we can change it.

If you check the example in the update command below, it's using the same name. It's better to distinguish them. Please evaluate further the feasibility of change as this is a common case in swagger.

Let me know if there's something I need to do here

src/connectedmachine/azext_connectedmachine/generated/_help.py

fengzhou-msft · 2020-09-15T09:53:37Z

src/connectedmachine/azext_connectedmachine/generated/_params.py

+    with self.argument_context('connectedmachine machine-extension show') as c:
+        c.argument('resource_group_name', resource_group_name_type)
+        c.argument('machine_name', type=str, help='The name of the machine containing the extension.', id_part='name')
+        c.argument('name', type=str, help='The name of the machine extension.', id_part='child_name_1')


Add options_list=['--name', '-n'].

@qiaozha when the argument name is name, the options are not added?

The code is generated. How would I do this in a generated way?

Ive added the change manually in this PR and in Azure/azure-rest-api-specs#10795

fengzhou-msft · 2020-09-15T09:54:59Z

src/connectedmachine/azext_connectedmachine/generated/_params.py

+        c.argument('resource_group_name', resource_group_name_type)
+        c.argument('machine_name', type=str, help='The name of the machine where the extension should be created or '
+                   'updated.')
+        c.argument('name', type=str, help='The name of the machine extension.')


Add options_list=['--name', '-n'] for name arguments in all below commands as well.

The code is generated. How would I do this in a generated way?

@qiaozha can we configure the options, probably using alias?

Ive added the change manually in this PR and in Azure/azure-rest-api-specs#10795

src/connectedmachine/azext_connectedmachine/tests/latest/test_connectedmachine_scenario.py

src/connectedmachine/azext_connectedmachine/generated/_help.py

Co-authored-by: Feng Zhou <[email protected]>

TylerLeonhardt · 2020-09-17T06:11:41Z

Awesome :) this should be ready to merge.

SDK Automation and others added 4 commits September 15, 2020 03:15

Generated from a35b1cd98e20d7c9b3c4fdcb23125b7ea85acca6

8636a96

add alias for auto_rev_minor_version

add tests

2947ae9

delete coverage file

1063663

add history

ba3149f

TylerLeonhardt mentioned this pull request Sep 15, 2020

Update connectedmachine extension #2362

Closed

3 tasks

yungezz assigned fengzhou-msft Sep 15, 2020

yungezz added the PLR PLR work label Sep 15, 2020

yungezz requested a review from fengzhou-msft September 15, 2020 05:24

fengzhou-msft reviewed Sep 15, 2020

View reviewed changes

src/connectedmachine/README.md Outdated Show resolved Hide resolved

fengzhou-msft reviewed Sep 15, 2020

View reviewed changes

src/connectedmachine/azext_connectedmachine/generated/_help.py Outdated Show resolved Hide resolved

qiaozha mentioned this pull request Sep 15, 2020

automatically change the help info from create or update into create for create command update for update command Azure/autorest.az#553

Closed

fengzhou-msft reviewed Sep 15, 2020

View reviewed changes

src/connectedmachine/azext_connectedmachine/generated/_help.py Outdated Show resolved Hide resolved

fengzhou-msft reviewed Sep 15, 2020

View reviewed changes

src/connectedmachine/azext_connectedmachine/tests/latest/test_connectedmachine_scenario.py Show resolved Hide resolved

TylerLeonhardt mentioned this pull request Sep 15, 2020

Additional changes for az CLI Azure/azure-rest-api-specs#10795

Merged

10 tasks

TylerLeonhardt added 3 commits September 15, 2020 17:49

update README

662b0fd

fix typo originally from swagger

03b3595

add aliases

c483ef6

fengzhou-msft reviewed Sep 17, 2020

View reviewed changes

src/connectedmachine/azext_connectedmachine/generated/_help.py Outdated Show resolved Hide resolved

fengzhou-msft reviewed Sep 17, 2020

View reviewed changes

src/connectedmachine/azext_connectedmachine/generated/_help.py Outdated Show resolved Hide resolved

GET to Get

57b6a07

Co-authored-by: Feng Zhou <[email protected]>

fengzhou-msft approved these changes Sep 17, 2020

View reviewed changes

fengzhou-msft merged commit a3bc42c into Azure:master Sep 17, 2020

TylerLeonhardt deleted the sdkAutomation/connectedmachine@10789 branch September 17, 2020 14:15

Update connectedmachine extension #2364

Update connectedmachine extension #2364

Uh oh!

Conversation

TylerLeonhardt commented Sep 15, 2020

General Guidelines

About Extension Publish

Uh oh!

azuresdkci commented Sep 15, 2020

Uh oh!

yungezz commented Sep 15, 2020

Uh oh!

TylerLeonhardt commented Sep 15, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TylerLeonhardt commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TylerLeonhardt commented Sep 17, 2020 •

edited

Loading