Skip to content

Conversation

@gavinfish
Copy link
Contributor


For VNet Injection instance, Azure Spring Cloud instance should be in the same location as the target VNet.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@gavinfish gavinfish added the Spring Cloud Spring Cloud related issues label Sep 1, 2020
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/VSChina/azure-cli-extensions.git@jieshe/vnet-location#subdirectory=src/$EXT&egg=$EXT"

raise CLIError('--app-subnet and --service-runtime-subnet should not be the same.')

vnet_obj = _get_vnet(cmd, vnet_id)
instance_location = namespace.location
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will there be format difference? like west us vs westus. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@yungezz
Copy link
Member

yungezz commented Sep 2, 2020

pls resolve conflict, then good to go.

@Azure Azure deleted a comment from yonzhan Sep 2, 2020
# Conflicts:
#	src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_validator.py
@yungezz yungezz merged commit db3d62e into Azure:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Spring Cloud Spring Cloud related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants