Skip to content

Conversation

@gavinfish
Copy link
Contributor


Disable role assignment check for vnet for Azure Spring Cloud. As checking role assignments for target VNet needs permissions to call AAD, this may block some customers in extreme circumstance when their az account does not have such permissions.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/VSChina/azure-cli-extensions.git@jieshe/disable-permission-check#subdirectory=src/$EXT&egg=$EXT"

@gavinfish gavinfish added the Spring Cloud Spring Cloud related issues label Aug 31, 2020
@Azure Azure deleted a comment from yonzhan Sep 1, 2020
@yungezz
Copy link
Member

yungezz commented Sep 1, 2020

hi @fengzhou-msft could you pls help to review? thanks.

@yungezz
Copy link
Member

yungezz commented Sep 1, 2020

hi @gavinfish even removing the check in Azure CLI side, will there be authorization check at service side, such as NRP?

Copy link
Member

@yungezz yungezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinfish
Copy link
Contributor Author

hi @gavinfish even removing the check in Azure CLI side, will there be authorization check at service side, such as NRP?

Yes, this will be checked from service side with specific SP.

@yungezz yungezz merged commit 4edd424 into Azure:master Sep 1, 2020
@gavinfish gavinfish deleted the jieshe/disable-permission-check branch January 13, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Spring Cloud Spring Cloud related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants