Skip to content

[Network] az network vwan create/upate: Remove the stale argument --vnet-to-vnet-traffic #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsntcy merged 4 commits into from
Sep 2, 2020
Merged

[Network] az network vwan create/upate: Remove the stale argument --vnet-to-vnet-traffic #2237

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a494fa4
[Network] Remove --vnet-to-vnet-traffic which is stale from command {…
jsntcy Aug 27, 2020
cc60b4c
Merge branch 'master' of https://github.com/Azure/azure-cli-extension…
jsntcy Sep 2, 2020
4dcb888
update version in setup.py
jsntcy Sep 2, 2020
4d253da
Update src/virtual-wan/HISTORY.rst
jsntcy Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/virtual-wan/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

0.2.1
++++++
* `az network vwan create/update`: Remove the stale argument `--vnet-to-vnet-traffic`.

@mmyyrroonn mmyyrroonn Aug 27, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding breaking change here?

Comment thread
jsntcy marked this conversation as resolved.
Outdated
Comment thread
jsntcy marked this conversation as resolved.
Outdated

0.2.0
++++++
* `az network vhub route-table`: Support virtual hub v3 route table.
Expand Down
1 change: 0 additions & 1 deletion src/virtual-wan/azext_vwan/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def load_arguments(self, _):
c.argument('virtual_wan_name', vwan_name_type, options_list=['--name', '-n'])
c.argument('location', get_location_type(self.cli_ctx), validator=get_default_location_from_resource_group)
c.argument('branch_to_branch_traffic', arg_type=get_three_state_flag(), help='Allow branch-to-branch traffic flow.')
c.argument('vnet_to_vnet_traffic', arg_type=get_three_state_flag(), help='Allow VNet-to-VNet traffic flow.')
c.argument('security_provider_name', help='The security provider name.')
c.argument('office365_category', help='The office local breakout category.')
c.argument('disable_vpn_encryption', arg_type=get_three_state_flag(), help='State of VPN encryption.')
Expand Down
7 changes: 2 additions & 5 deletions src/virtual-wan/azext_vwan/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def _find_item_at_path(instance, path):
# region VirtualWAN
def create_virtual_wan(cmd, resource_group_name, virtual_wan_name, tags=None, location=None,
security_provider_name=None, branch_to_branch_traffic=None,
vnet_to_vnet_traffic=None, office365_category=None, disable_vpn_encryption=None,
office365_category=None, disable_vpn_encryption=None,
vwan_type=None):
client = network_client_factory(cmd.cli_ctx).virtual_wans
VirtualWAN = cmd.get_models('VirtualWAN')
Expand All @@ -100,21 +100,18 @@ def create_virtual_wan(cmd, resource_group_name, virtual_wan_name, tags=None, lo
disable_vpn_encryption=disable_vpn_encryption,
security_provider_name=security_provider_name,
allow_branch_to_branch_traffic=branch_to_branch_traffic,
allow_vnet_to_vnet_traffic=vnet_to_vnet_traffic,
office365_local_breakout_category=office365_category,
type=vwan_type
)
return client.create_or_update(resource_group_name, virtual_wan_name, wan)


def update_virtual_wan(instance, tags=None, security_provider_name=None, branch_to_branch_traffic=None,
vnet_to_vnet_traffic=None, office365_category=None, disable_vpn_encryption=None,
vwan_type=None):
office365_category=None, disable_vpn_encryption=None, vwan_type=None):
with UpdateContext(instance) as c:
c.update_param('tags', tags, True)
c.update_param('security_provider_name', security_provider_name, False)
c.update_param('allow_branch_to_branch_traffic', branch_to_branch_traffic, False)
c.update_param('allow_vnet_to_vnet_traffic', vnet_to_vnet_traffic, False)
c.update_param('office365_local_breakout_category', office365_category, False)
c.update_param('disable_vpn_encryption', disable_vpn_encryption, False)
c.update_param('type', vwan_type, False)
Expand Down