[hpc-cache] Bug fix, code refactoring and perfect test cases #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
hpc-cache |
zhoxing-ms
force-pushed
the
hpc_cache_refactor
branch
3 times, most recently
from
ce532a7 to
82a88d9
Compare
jsntcy
reviewed
Aug 17, 2020
jsntcy
reviewed
Aug 17, 2020
jsntcy
reviewed
Aug 17, 2020
jsntcy
reviewed
Aug 17, 2020
jsntcy
reviewed
Aug 17, 2020
jsntcy
reviewed
Aug 17, 2020
zhoxing-ms
force-pushed
the
hpc_cache_refactor
branch
from
82a88d9 to
abf6d08
Compare
zhoxing-ms
force-pushed
the
hpc_cache_refactor
branch
from
abf6d08 to
6085cde
Compare
Juliehzl
reviewed
Aug 20, 2020
| @@ -1,5 +0,0 @@ | |||
| Microsoft Azure CLI 'hpc-cache' Extension | |||
Contributor
Author
There was a problem hiding this comment.
Because we already have README.md, so it is useless.
Juliehzl
reviewed
Aug 20, 2020
| DEPENDENCIES = [] | ||
|
|
||
| with open('README.rst', 'r', encoding='utf-8') as f: | ||
| with open('README.md', 'r', encoding='utf-8') as f: |
Contributor
There was a problem hiding this comment.
seems you don't have README.md file.
Contributor
Author
There was a problem hiding this comment.
Because there is this file originally, it is not added by me~
File link
mmyyrroonn
reviewed
Aug 20, 2020
jsntcy
reviewed
Aug 20, 2020
Juliehzl
approved these changes
Aug 20, 2020
zhoxing-ms
force-pushed
the
hpc_cache_refactor
branch
from
f9b36e8 to
917bfb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az hpc-cache updateis modified to update only tags.az hpc-cache nfs-storage-target updatewithout passing the parameter--junction.--junction.storage_accountsupports passing in the name of storage account.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.