Skip to content

Conversation

@JunSun17
Copy link
Contributor

@JunSun17 JunSun17 commented Aug 6, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/JunSun17/azure-cli-extensions.git@jusu-basic-lb#subdirectory=src/$EXT&egg=$EXT"

@JunSun17
Copy link
Contributor Author

JunSun17 commented Aug 6, 2020

This is for #2138

)
if load_balancer_sku.lower() == "basic":
network_profile = ContainerServiceNetworkProfile(
load_balancer_sku=load_balancer_sku.lower(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify whether you need to set network_plugin="kubenet" like L986

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in live test that network_plugin is not needed, it default to kubenet.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 6, 2020

aks

@yonzhan yonzhan requested a review from qwordy August 6, 2020 22:27
@JunSun17 JunSun17 changed the title Set network profile when using basic load balancer. [AKS] Set network profile when using basic load balancer. Aug 6, 2020
@yungezz
Copy link
Member

yungezz commented Aug 7, 2020

hi @fengzhou-msft could you pls help to review the PR?

@gtracer gtracer merged commit 0c1a948 into Azure:master Aug 10, 2020
@gtxistxgao gtxistxgao mentioned this pull request Aug 21, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants