-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Creating CLI extension for Azure Quantum #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Initial version.
Fixing style issues
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
Please use same tense in help. |
|
Are you still working on this PR? |
|
hi @anpaz-msft are you still on this PR? If yes, could you pls look at comments and fix CI failure? Feel free to ping us if any question. |
|
ping @anpaz-msft again for update |
|
Based on feedback I received offline, I was requested to hold this until Azure Quantum service in in public preview; currently we are on Private Preview. |
Code review feedback
|
@anpaz @ricardo-espinoza Thank you for your work on this PR! It is really a large PR. I will merge it now. I created a issue #2956. We can discuss and resolve them in later releases. |
| def _show_tip(msg): | ||
| import colorama | ||
| colorama.init() | ||
| print(f"\033[1m{colorama.Fore.YELLOW}{msg}{colorama.Style.RESET_ALL}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually, we output warnings to stderr. Is there any reason to allow them to be sent to stdout?
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.