AKS: add aks-custom-headers for nodepool and update#1686
Merged
arrownj merged 2 commits intoAzure:masterfrom May 14, 2020
Merged
AKS: add aks-custom-headers for nodepool and update#1686arrownj merged 2 commits intoAzure:masterfrom
arrownj merged 2 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Contributor
Author
|
/hold |
Contributor
Author
|
cc @palma21 |
Member
|
CC @zhedahht @xuto2 @gtxistxgao |
Collaborator
|
AKS |
2c38021 to
b46f158
Compare
add version change add parameters
b46f158 to
06bcae2
Compare
add help
56299ab to
7fa2742
Compare
Contributor
Author
|
PR is ready for review, thanks |
Contributor
Author
|
/assign @zhedahht @xuto2 @gtxistxgao @zqingqing1 |
yungezz
approved these changes
May 14, 2020
arrownj
reviewed
May 14, 2020
arrownj
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.Test result
az aks nodepool add ... CustomizedUbuntu=aks-ubuntu-1804az aks nodepool add ...(wrong aks-custom-headers format)--aks-custom-headers