Skip to content

AKS: add aks-custom-headers for nodepool and update#1686

Merged
arrownj merged 2 commits intoAzure:masterfrom
andyzhangx:aks-custom-headers
May 14, 2020
Merged

AKS: add aks-custom-headers for nodepool and update#1686
arrownj merged 2 commits intoAzure:masterfrom
andyzhangx:aks-custom-headers

Conversation

@andyzhangx
Copy link
Contributor

@andyzhangx andyzhangx commented May 12, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Test result

  • az aks nodepool add ... CustomizedUbuntu=aks-ubuntu-1804
# az aks nodepool add -g $RESOURCE_GROUP_NAME --cluster-name $CLUSTER_NAME --node-count 1 --kubernetes-version 1.15.10 --aks-custom-headers CustomizedUbuntu=aks-ubuntu-1804 -n andytest
The behavior of this command has been altered by the following extension: aks-preview
{
  "agentPoolType": "VirtualMachineScaleSets",
  "availabilityZones": null,
  "count": 1,
  "enableAutoScaling": null,
  "enableNodePublicIp": false,
  "id": "/subscriptions/xxx/resourcegroups/andy-aks11510/providers/Microsoft.ContainerService/managedClusters/andy-aks11510/agentPools/andytest",
  "maxCount": null,
  "maxPods": 110,
  "minCount": null,
  "mode": "User",
  "name": "andytest",
  "nodeLabels": null,
  "nodeTaints": null,
  "orchestratorVersion": "1.15.10",
  "osDiskSizeGb": 100,
  "osType": "Linux",
  "provisioningState": "Succeeded",
  "resourceGroup": "andy-aks11510",
  "scaleSetEvictionPolicy": null,
  "scaleSetPriority": null,
  "spotMaxPrice": null,
  "tags": null,
  "type": "Microsoft.ContainerService/managedClusters/agentPools",
  "vmSize": "Standard_DS2_v2",
  "vnetSubnetId": null
}
  • az aks nodepool add ... (wrong aks-custom-headers format)
# az aks nodepool add -g $RESOURCE_GROUP_NAME --cluster-name $CLUSTER_NAME --node-count 1 --kubernetes-version 1.15.10 --aks-custom-headers CustomizedUbunt -n andytest2
The behavior of this command has been altered by the following extension: aks-preview
custom headers format is incorrect
  • Without --aks-custom-headers
# az aks nodepool add -g $RESOURCE_GROUP_NAME --cluster-name $CLUSTER_NAME --node-count 1 --kubernetes-version 1.15.10 -n andytest2
The behavior of this command has been altered by the following extension: aks-preview
{
  "agentPoolType": "VirtualMachineScaleSets",
  "availabilityZones": null,
  "count": 1,
  "enableAutoScaling": null,
  "enableNodePublicIp": false,
  "id": "/subscriptions/xxx/resourcegroups/andy-aks11510/providers/Microsoft.ContainerService/managedClusters/andy-aks11510/agentPools/andytest2",
  "maxCount": null,
  "maxPods": 110,
  "minCount": null,
  "mode": "User",
  "name": "andytest2",
  "nodeLabels": null,
  "nodeTaints": null,
  "orchestratorVersion": "1.15.10",
  "osDiskSizeGb": 100,
  "osType": "Linux",
  "provisioningState": "Succeeded",
  "resourceGroup": "andy-aks11510",
  "scaleSetEvictionPolicy": null,
  "scaleSetPriority": null,
  "spotMaxPrice": null,
  "tags": null,
  "type": "Microsoft.ContainerService/managedClusters/agentPools",
  "vmSize": "Standard_DS2_v2",
  "vnetSubnetId": null
}

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/andyzhangx/azure-cli-extensions.git@aks-custom-headers#subdirectory=src/$EXT&egg=$EXT"

@andyzhangx
Copy link
Contributor Author

/hold

@andyzhangx
Copy link
Contributor Author

cc @palma21

@andyzhangx andyzhangx changed the title feat: add aks-custom-headers for nodepool and update [WIP]feat: add aks-custom-headers for nodepool and update May 12, 2020
@palma21
Copy link
Member

palma21 commented May 12, 2020

CC @zhedahht @xuto2 @gtxistxgao
Thanks @andyzhangx !

@yonzhan yonzhan requested review from fengzhou-msft and qwordy May 12, 2020 22:35
@yonzhan yonzhan added this to the S169 milestone May 12, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented May 12, 2020

AKS

@yungezz yungezz added the AKS label May 13, 2020
@yungezz yungezz removed this from the S169 milestone May 13, 2020
@andyzhangx andyzhangx force-pushed the aks-custom-headers branch from 2c38021 to b46f158 Compare May 13, 2020 06:18
@andyzhangx andyzhangx changed the title [WIP]feat: add aks-custom-headers for nodepool and update feat: add aks-custom-headers for nodepool and update May 13, 2020
add version change

add parameters
@andyzhangx andyzhangx force-pushed the aks-custom-headers branch from b46f158 to 06bcae2 Compare May 13, 2020 06:36
@andyzhangx andyzhangx changed the title feat: add aks-custom-headers for nodepool and update [WIP]feat: add aks-custom-headers for nodepool and update May 13, 2020
@andyzhangx andyzhangx force-pushed the aks-custom-headers branch from 56299ab to 7fa2742 Compare May 13, 2020 08:15
@andyzhangx andyzhangx changed the title [WIP]feat: add aks-custom-headers for nodepool and update feat: add aks-custom-headers for nodepool and update May 13, 2020
@andyzhangx andyzhangx changed the title feat: add aks-custom-headers for nodepool and update AKS: add aks-custom-headers for nodepool and update May 13, 2020
@andyzhangx
Copy link
Contributor Author

PR is ready for review, thanks

@andyzhangx
Copy link
Contributor Author

/assign @zhedahht @xuto2 @gtxistxgao @zqingqing1
can you take a review? thanks.

@arrownj arrownj self-requested a review May 14, 2020 01:56
@arrownj arrownj merged commit fb40791 into Azure:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants