spring-cloud: add support to enable/disable MSI (#1523) #1671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonard520
changed the title
Member
|
hi @leonard520 is there any change between this PR with previous PR? that one was reviewed and approved already |
Contributor
Author
They are the same except I raise the version number to 0.2.4 in this one |
Member
|
thanks for clarification. Then just ping us when the PR is ready to merge, thanks. @leonard520 |
Contributor
Author
|
@yungezz @fengzhou-msft The backend is ready. Please help to merge the code. Thanks! |
leonard520
changed the title
fengzhou-msft
approved these changes
May 27, 2020
qwordy
reviewed
May 27, 2020
Member
|
Could you please add a brief description for this PR and link the previous same PR that is reviewed? |
Contributor
Author
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1671 in repo Azure/azure-cli-extensions |
leonard520
requested review from
Juliehzl,
aim-for-better,
gtracer,
haroldrandom,
idear1203,
jiasli and
jsntcy
as code owners
qwordy
removed request for
Juliehzl,
aim-for-better,
gtracer,
haroldrandom,
idear1203,
jiasli,
jsntcy,
kalyanaj and
zqingqing1
qwordy
reviewed
May 27, 2020
Co-authored-by: Feiyue Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command "az spring-cloud app identity" to support Managed Identity feature
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.