-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Breadth Coverage] Onboard Custom Providers Commands #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
3ba3ab5 to
de3dafe
Compare
|
add to S169 |
mmyyrroonn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Cheers
src/custom-providers/azext_custom_providers/tests/latest/test_custom-providers_scenario.py
Show resolved
Hide resolved
src/custom-providers/azext_custom_providers/tests/latest/test_custom-providers_scenario.py
Show resolved
Hide resolved
| body = {'location': location, 'tags': tags, | ||
| 'actions': actions, 'resource_types': resource_types, | ||
| 'validations': validations} | ||
| return sdk_no_wait(no_wait, client.create_or_update, resource_group_name=resource_group_name, resource_provider_name=resource_provider_name, resource_provider=body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example
What does this PR do?
Which commands will be supported?
az custom-providers resource-provider createaz custom-providers resource-provider updateaz custom-providers resource-provider showaz custom-providers resource-provider deleteaz custom-providers resource-provider listThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: