vm-repair: Bug Fix when HyperV-version Variable is None

[swbae31]

Quick few liner bug fix when the HyperV-version variable is none

[yonzhan]

add to S168

[swbae31]

@yonzhan
I got an error from merge validation that
"Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically."

Has some process changed for PRs?

[yonzhan]

Yes, the process is changed to automatically release extensions. @haroldrandom can help with it.

[yonzhan]

You should not change source code and index.json at the same time right now.

[haroldrandom]

src/index.json should't modify both in one PR, we have a release pipeline for publishing your extension automatically.
If you want to use it and hold extension wheel on CLI's official container, just leave src/index.json untouched. After this PR merge, another RP to update src/index.json will be created automatically.
If you still want to hold it in your own container, just fire another PR to update the src/index.json separately.

The detail should be listed in PR template, captured from other PR:

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[qwordy]

Looks good to me.

[swbae31]

Got it. That's great. Creating the wheel file, uploading it, and making the hash has always been really tedious and made PR changes difficult. This is an awesome change. Thanks.

Then when does the release pipeline happen? And how would I know it has been released with the index.json updated?

[yungezz]

hi @qwordy could you pls help to review/merge this PR? thanks

[haroldrandom]

@swbae31

Then when does the release pipeline happen?
It's triggered once PR is merged into master branch but only build and upload only when extension upgrade (detecting via version).

Normally PR developer won't get notifed for the PR to update src/index.json, @fengzhou-msft and I will get notification once because code owner review mechanism. We will assign it to the assignee who responsible for the source PR to trigger this one, then approve it.
You can have a look how the other extension works. :)

[qwordy]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).