[Breadth Coverage] logic apps

[bquantump]

Speclet: https://aka.ms/AA7txib

Files to focus on:

Since there are many generated files, the following are a list files that have been manually changed and hence should be the primary focus for the review:

• src/logic/azext_logic/generated/custom.py
• src/logic/azext_logic/generated/_help.py
• src/logic/azext_logic/generated/_params.py
• src/logic/azext_logic/tests/latest/workflow.json
• src/logic/azext_logic/tests/latest/integration.json
• src/logic/azext_logic/vendored_sdks/logic/operations/_workflow_operations.py
• src/logic/azext_logic/vendored_sdks/logic/operations/_integration_account_operations.py
• src/logic/azext_logic/tests/latest/test_logic_scenario.py

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[yonzhan]

logic apps

[qwordy]

Connect your business-critical apps and services with Azure Logic Apps, automating your workflows without writing a single line of code.

Copied from logic apps homepage. I think workflow.json is also a form of code.

[qwordy]

In az logic workflow create,

--access-control                  : The access control configuration.
--endpoints-configuration         : The endpoints configuration.
--integration-account             : The integration account.
--integration-service-environment : The integration service environment.

The help messages provide nothing. They are same as parameter name. I don't know how to use it. What's the format of value? I also can't find usage in examples.
I haven't traversed all commands and parameters helps and examples, I highly suggest the author check them carefully to ensure a new user can learn to use logic app easily.

[bquantump]

Note sure how to fix the codeowner issue, I added myself to the .git/b

In az logic workflow create,

--access-control                  : The access control configuration.
--endpoints-configuration         : The endpoints configuration.
--integration-account             : The integration account.
--integration-service-environment : The integration service environment.

The help messages provide nothing. They are same as parameter name. I don't know how to use it. What's the format of value? I also can't find usage in examples.
I haven't traversed all commands and parameters helps and examples, I highly suggest the author check them carefully to ensure a new user can learn to use logic app easily.

I could certainly add some more description here, but these parameters really do not lend themselves to a terse descriptions. For example, and integration service environment and account are connected to on premise subnets or Azure virtual networks that logic app can connect to to call either custom on premise services or custom services running on Azure. Logic apps are not something, I think, we should expect someone to try to use the CLI for without understanding these concepts before hand. This is part of the reason the logic app team has invested so much effort into their design tools.

[bquantump]

Not sure why a unrelated test is failing.

[fengzhou-msft]

Not sure why a unrelated test is failing.

There should be a button to require you to merge master if your branch do not have the latest master branch code. It's somehow gone. You can manually merge master and the issue of firewall should be fixed.