Skip to content

Conversation

@JunSun17
Copy link
Contributor

@JunSun17 JunSun17 commented Feb 19, 2020


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@JunSun17 JunSun17 requested a review from zqingqing1 as a code owner February 19, 2020 00:23
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/JunSun17/azure-cli-extensions.git@jusu-fix-nonetype#subdirectory=src/$EXT&egg=$EXT"

@xizha162
Copy link
Contributor

/LGTM

@JunSun17 JunSun17 requested a review from zikalino February 19, 2020 18:15
@JunSun17
Copy link
Contributor Author

@zikalino Can you help to approve and merge this change, thanks!

@jluk
Copy link

jluk commented Feb 20, 2020

@qwordy can you merge this as well? It is the same fix as the one merged below, but for the preview extension.

Azure/azure-cli#12250

@yungezz yungezz merged commit 9c11017 into Azure:master Feb 21, 2020
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants