Skip to content

Conversation

@haroldrandom
Copy link
Contributor

@haroldrandom haroldrandom commented Feb 4, 2020

#1238 's follow up.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@haroldrandom haroldrandom self-assigned this Feb 4, 2020
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/haroldrandom/azure-cli-extensions.git@connection-monitor-v2-index#subdirectory=src/$EXT&egg=$EXT"

@haroldrandom haroldrandom force-pushed the connection-monitor-v2-index branch from 16a5b50 to a4d98ff Compare February 4, 2020 10:28
@haroldrandom haroldrandom marked this pull request as ready for review February 4, 2020 14:10
@haroldrandom haroldrandom merged commit f751867 into Azure:master Feb 4, 2020
@haroldrandom haroldrandom deleted the connection-monitor-v2-index branch February 4, 2020 15:22
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants