Skip to content

Hotfix az rewrite and storage_preview #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmyyrroonn merged 5 commits into from
Nov 7, 2019
Merged

Hotfix az rewrite and storage_preview #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e03f67
Disallow failures on Travis CI
Nov 6, 2019
45bfa50
Hotfix: bug introcuded by azure-cli #155b6bc
Nov 7, 2019
7a23218
Update wrong sha256 of storage_preview
Nov 7, 2019
33fd203
Update azext.minCliCoreVersion of storage_preview
Nov 7, 2019
9527b4d
Skip two checks from azure-cli's azdev for hotfix
Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,3 @@ jobs:
env: PURPOSE='SyncAvailableExtensionsDoc'
if: repo = Azure/azure-cli-extensions and branch = master and type = cron
fast_finish: true
allow_failures:
- env: PURPOSE='SourceTests'
26 changes: 15 additions & 11 deletions scripts/ci/verify_modified_index.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ set -ex
# Install CLI & Dev Tools
echo "Installing azure-cli-dev-tools and azure-cli..."
git clone --single-branch -b dev https://github.com/Azure/azure-cli.git ../azure-cli
python ../azure-cli/scripts/dev_setup.py
pip install -e "git+https://github.com/Azure/azure-cli@dev#egg=azure-cli-dev-tools&subdirectory=tools" -q

pip install azdev
azdev setup -c ../azure-cli

echo "Installed."
az --version
set +x
Expand All @@ -26,17 +28,19 @@ while read line; do
echo
echo "New index entries detected for extension:" $ext
echo "Adding latest entry from source:" $source
set +e

az extension add -s $source -y
if [ $? != 0 ]; then
continue
fi
set -e
echo "Load all commands"
azdev verify load-all
echo "Running linter"
azdev cli-lint --ci --extensions $ext

# TODO migrate to public azdev
echo "Load all commands..."
# azdev verify load-all

# TODO migrate to public azdev
echo "Running linter..."
# azdev cli-lint --ci --extensions $ext
Copy link
Contributor

@mmyyrroonn mmyyrroonn Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we run the azdev linter and azdev verify load-all?

Copy link
Contributor Author

@haroldrandom haroldrandom Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the public azdev doesn't have those two commands. So it's a dangerous hotfix which will open the Pandora Box that leave extension commands without some correctness verification.


az extension remove -n $ext

echo $ext "extension has been removed."
done <<< "$modified_extensions"

Expand Down
4 changes: 2 additions & 2 deletions src/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,7 @@
"filename": "storage_preview-0.2.9-py2.py3-none-any.whl",
"metadata": {
"azext.isPreview": true,
"azext.minCliCoreVersion": "2.0.52",
"azext.minCliCoreVersion": "2.0.67",
"classifiers": [
"Development Status :: 4 - Beta",
"Intended Audience :: Developers",
Expand Down Expand Up @@ -2218,7 +2218,7 @@
"summary": "Provides a preview for upcoming storage features.",
"version": "0.2.9"
},
"sha256Digest": "211afaf23a6340671fee8a4b9e7c982f28b9ec9d1bf2e403fcc9de08c561ab7b"
"sha256Digest": "880e01de0fab8893770497ef9410559ae223a1f09dbd6a23712226ab4e2d5ecb"
}
],
"subscription": [
Expand Down