Skip to content

adding connectedmachine to index#1042

Merged
zikalino merged 3 commits intomasterfrom
connectedmachine-to-index
Oct 31, 2019
Merged

adding connectedmachine to index#1042
zikalino merged 3 commits intomasterfrom
connectedmachine-to-index

Conversation

@zikalino
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@connectedmachine-to-index#subdirectory=src/$EXT&egg=$EXT"

@zikalino zikalino requested a review from farehar October 30, 2019 23:05
@Juliehzl Juliehzl self-requested a review October 31, 2019 01:49
Copy link
Contributor

@Juliehzl Juliehzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zikalino zikalino merged commit 5c40331 into master Oct 31, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
* adding connectedmachine to index

* fixing dependencies

* adding connectedmachine to index again
@wangzelin007 wangzelin007 deleted the connectedmachine-to-index branch November 18, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants