Skip to content

add --zones and -z commands to aks-preview to make it compatible with azure-cli #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zikalino merged 4 commits into from
Oct 30, 2019
Merged

add --zones and -z commands to aks-preview to make it compatible with azure-cli #1039

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5f97ba
add --zones and -zones commands to preview
Oct 30, 2019
0fea80d
add seperation between parameters
Oct 30, 2019
8bf2225
mention that --node-zones will be depreciated
Oct 30, 2019
c00bd88
fix typo
Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

Release History
===============
0.4.20
+++++
* Add commands '--zones' and '-z' for availability zones in aks

0.4.19
+++++
* Refactor and remove a custom way of getting subscriptions
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ az aks create \
-g MyResourceGroup \
-n MyManagedCluster \
--vm-set-type VirtualMachineScaleSets \
--node-zones 1 2 3
--zones 1 2 3
```

#### Enable pod security policy for new cluster
Expand Down
5 changes: 4 additions & 1 deletion src/aks-preview/azext_aks_preview/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,10 @@
long-summary: If not specified, defaults to 110, or 30 for advanced networking configurations.
- name: --node-zones
type: string array
short-summary: (PREVIEW) Availability zones where agent nodes will be placed.
short-summary: (will be depreciated use --zones) Availability zones where agent nodes will be placed.
Comment thread
adilliadil marked this conversation as resolved.
Outdated
- name: --zones -z
type: string array
short-summary: Availability zones where agent nodes will be placed.
- name: --vnet-subnet-id
type: string
short-summary: The ID of a subnet in an existing VNet into which to deploy the cluster.
Expand Down
4 changes: 2 additions & 2 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def load_arguments(self, _):
c.argument('max_count', type=int, validator=validate_nodes_count)
c.argument('enable_vmss', action='store_true', help='To be deprecated. Use vm_set_type instead.')
c.argument('vm_set_type', type=str, validator=validate_vm_set_type)
c.argument('node_zones', zones_type, options_list='--node-zones', help='(PREVIEW) Space-separated list of availability zones where agent nodes will be placed.')
c.argument('node_zones', zones_type, options_list=['--node-zones', '--zones', '-z'], help='(--node-zones will be depreciated) Space-separated list of availability zones where agent nodes will be placed.')
Comment thread
adilliadil marked this conversation as resolved.
Outdated
Comment thread
adilliadil marked this conversation as resolved.
Outdated
c.argument('enable_pod_security_policy', action='store_true')
c.argument('node_resource_group')
c.argument('attach_acr', acr_arg_type)
Expand Down Expand Up @@ -113,7 +113,7 @@ def load_arguments(self, _):
for scope in ['aks nodepool add']:
with self.argument_context(scope) as c:
c.argument('nodepool_name', type=str, options_list=['--name', '-n'], validator=validate_nodepool_name, help='The node pool name.')
c.argument('node_zones', zones_type, options_list='--node-zones', help='(PREVIEW) Space-separated list of availability zones where agent nodes will be placed.')
c.argument('node_zones', zones_type, options_list=['--node-zones', '--zones', '-z'], help='(--node-zones will be depreciated) Space-separated list of availability zones where agent nodes will be placed.')
Comment thread
adilliadil marked this conversation as resolved.
Outdated
Comment thread
adilliadil marked this conversation as resolved.
Outdated
c.argument('node_vm_size', options_list=['--node-vm-size', '-s'], completer=get_vm_size_completion_list)
c.argument('max_pods', type=int, options_list=['--max-pods', '-m'], validator=validate_max_pods)
c.argument('os_type', type=str)
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from codecs import open as open1
from setuptools import setup, find_packages

VERSION = "0.4.19"
VERSION = "0.4.20"
CLASSIFIERS = [
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
Expand Down