[Storage] Fix #10620 in azure cli to support ADLS#1038
Merged
Juliehzl merged 46 commits intoAzure:masterfrom Oct 31, 2019
Merged
[Storage] Fix #10620 in azure cli to support ADLS#1038Juliehzl merged 46 commits intoAzure:masterfrom
Juliehzl merged 46 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
zikalino
reviewed
Oct 31, 2019
src/storage-preview/azext_storage_preview/tests/latest/test_storage_adls_scenarios.py
Outdated
Show resolved
Hide resolved
zikalino
reviewed
Oct 31, 2019
zikalino
reviewed
Oct 31, 2019
zikalino
approved these changes
Oct 31, 2019
zikalino
left a comment
zikalino
left a comment
There was a problem hiding this comment.
i am ok with merging it, couldn't check every single detail though.
anyway the ux and tests look good.
just left a few comments.
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
* add az storage blob directory and enable _help in extension * add access in blob directory * update params.py * add some test * update help and test * update test * add upload * upgrade azcopy to v10.3.1 and refine download command * add test for upload * add download command * fix bug for 'az storage blob directory -h' * change the api version name and re-record test * remoce useless azcopy package * update version and re-record test * add az storage blob directory and enable _help in extension * add access in blob directory * update params.py * add some test * update help and test * update test * add upload * upgrade azcopy to v10.3.1 and refine download command * add test for upload * add download command * fix bug for 'az storage blob directory -h' * change the api version name and re-record test * remoce useless azcopy package * update version and re-record test * fix style * remove conflicts sign in _params.py * remove conflicts sign in _help.py * remove conflicts sign in blob.py * remove conflict sign in test_storage_adls_scenariods.py * remove unuseless comment * remove useless function and fix style * remove useless transform_url * remove useless upload_blob() and guess_content_type() * fix style to remove unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: