[Network]Support azure firewall policy and its child resource/ support fqdns for network/application rules#1033
Merged
zikalino merged 8 commits intoAzure:masterfrom Oct 31, 2019
Conversation
… for network/applicatoin rule
zikalino
approved these changes
Oct 31, 2019
|
looks very good. i am really surprised how you can make such large implementation without codegen :-) |
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…t fqdns for network/application rules (Azure#1033) * Bump SDK Dependency * support firewall policy and its child resource CRUD and support fqdns for network/applicatoin rule * add test * recording the test * fix style and add required for one argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure/azure-cli#10703
Azure/azure-cli#10725
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: