Skip to content

Conversation

@xizha162
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@xizha162 xizha162 requested a review from zqingqing1 as a code owner October 30, 2019 01:06
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/xizhamsft/azure-cli-extensions.git@xizha-peri#subdirectory=src/$EXT&egg=$EXT"

@xizha162 xizha162 force-pushed the xizha-peri branch 2 times, most recently from 80aab0d to ba0683f Compare November 1, 2019 17:58
Copy link
Contributor

@JunSun17 JunSun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

Some wording comments inline.

@xizha162 xizha162 force-pushed the xizha-peri branch 5 times, most recently from e77a1ef to 2ce2b76 Compare November 4, 2019 23:14
@xizha162 xizha162 changed the title Implement az aks kshow command to display the diagnostics information Implement az aks kanalyze command to display the diagnostics information Nov 5, 2019
@zikalino zikalino merged commit b361092 into Azure:master Nov 5, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants