Skip to content

aks-preview extension release v0.4.19#1030

Merged
zikalino merged 1 commit intoAzure:masterfrom
bingosummer:aks
Oct 30, 2019
Merged

aks-preview extension release v0.4.19#1030
zikalino merged 1 commit intoAzure:masterfrom
bingosummer:aks

Conversation

@bingosummer
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/bingosummer/azure-cli-extensions.git@aks#subdirectory=src/$EXT&egg=$EXT"

@bingosummer
Copy link
Member Author

@zikalino @zqingqing1 please have a look.

@zikalino
Copy link

zikalino commented Oct 29, 2019

@bingosummer no need to have 2 entries in index.json, you can remove the old one
just to make sure you can compare them to make sure there's nothing specific the new entry is using.

we usually can have 2 entries, if the new release doesn't support some older version of Azure CLI core, and I think it's not the case here.

@bingosummer
Copy link
Member Author

bingosummer commented Oct 29, 2019

@bingosummer no need to have 2 entries in index.json, you can remove the old one
just to make sure you can compare them to make sure there's nothing specific the new entry is using.

we usually can have 2 entries, if the new release doesn't support some older version of Azure CLI core, and I think it's not the case here.

@zikalino Got your point. Have removed the old one.

@bingosummer
Copy link
Member Author

@zikalino Thanks for your kindly review!
Just out of curiosity, if we keep only the latest version in index.json, can customers install the old versions of extension?

@zikalino zikalino merged commit 76444e7 into Azure:master Oct 30, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants