vm-repair 0.2.3: Enable custom vm username for linux repair VM, add more validators#1004
Merged
zikalino merged 6 commits intoAzure:masterfrom Nov 5, 2019
Merged
vm-repair 0.2.3: Enable custom vm username for linux repair VM, add more validators#1004zikalino merged 6 commits intoAzure:masterfrom
zikalino merged 6 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
…dict for repair run
Collaborator
|
@zikalino will help review. |
Contributor
Author
zikalino
approved these changes
Nov 5, 2019
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…ore validators (Azure#1004) * Enable custom username for linux repair vm creation. Add password, username validator. * Update telemetry so that command is success when script fails for repair run * Edit e2e tests * Fix messsage typo for telemetry and up version to 0.2.3 * Hide long running message when verbose. Show script status as return dict for repair run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for merge after signoff
Changes: