Skip to content

vm-repair 0.2.3: Enable custom vm username for linux repair VM, add more validators#1004

Merged
zikalino merged 6 commits intoAzure:masterfrom
swbae31:version0.2.3
Nov 5, 2019
Merged

vm-repair 0.2.3: Enable custom vm username for linux repair VM, add more validators#1004
zikalino merged 6 commits intoAzure:masterfrom
swbae31:version0.2.3

Conversation

@swbae31
Copy link
Contributor

@swbae31 swbae31 commented Oct 16, 2019

Ready for merge after signoff

Changes:

  1. Enable custom vm username for Linux repair VMs
  2. Rename scenario tests to better match doc format
  3. Add vm password and username validators for fast fails when user provides bad input
  4. fix Typos
  5. Run command will return with status SUCCESS even when the script itself fails. However the script status will return with ERROR.
  6. Hide long running messages when --verbose
  7. Return script_status in return json for repair run command

@swbae31 swbae31 requested a review from zikalino as a code owner October 16, 2019 17:43
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/swbae31/azure-cli-extensions.git@version0.2.3#subdirectory=src/$EXT&egg=$EXT"

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 19, 2019

@zikalino will help review.

@swbae31
Copy link
Contributor Author

swbae31 commented Oct 23, 2019

@zikalino @yonzhan any updates on this?

@zikalino zikalino merged commit 94c7755 into Azure:master Nov 5, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
…ore validators (Azure#1004)

* Enable custom username for linux repair vm creation. Add password, username validator.

* Update telemetry so that command is success when script fails for repair
run

* Edit e2e tests

* Fix messsage typo for telemetry and up version to 0.2.3

* Hide long running message when verbose. Show script status as return dict for repair run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants