Skip to content

Bump pylint to 3 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 2 commits into from
Jul 25, 2024
Merged

Bump pylint to 3 #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b66c9
Init
bebound Jul 12, 2024
193de54
Minor fix
bebound Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions azdev/operations/linter/pylint_checkers/show_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
import astroid

from pylint.checkers import BaseChecker
from pylint.interfaces import IAstroidChecker
Copy link
Contributor Author

@bebound bebound Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything related to the __implements__ construct was removed. It was based on PEP245 that was proposed in 2001 and rejected in 2006.

All the classes inheriting Interface in pylint.interfaces were removed. Checker should only inherit BaseChecker or any of the other checker types from pylint.checkers. Reporter should only inherit BaseReporter.

Refs #8404 (#8404)

Ref: https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html



class ShowCommandChecker(BaseChecker):
__implements__ = IAstroidChecker

name = 'show-command'
priority = -1
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
'gitpython',
'jinja2',
'knack',
'pylint>=2.12,<3',
'pylint<4',
'pytest-xdist', # depends on pytest-forked
'pytest-forked',
'pytest>=5.0.0',
Expand Down