load parameter from module loader #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Contributor
Author
|
jiasli
reviewed
Jun 1, 2023
kairu-ms
approved these changes
Jun 2, 2023
RenSilvaAU
pushed a commit
to RenSilvaAU/azure-cli-dev-tools
that referenced
this pull request
Aug 7, 2025
…n-issue Uninherited read-only flag for CMDClsSchemaBase code generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_applicabilitytriggers theArgumentsContextto parse and merge arguments' kwargs from various sources. If not settled, arguments' kwargs is based on the cmd's customization function (don't know what's this action's purpose but its impact is what it is).In this issue, because parameter
show_auth_for_sdkorshow_auth_in_jsonis parsed from its customization function, without itsArgumentsContextconfiguredoptions_list, so they are marked as different parameter.After set
skip_applicability=True,options_listis used to binding these two parameters and currentazdev command-change meta-difftool can comprehend that[--sdk-auth]is included in[--sdk-auth, --json-auth]and can be reviewed as the same parameter for users (see https://github.com/AllyW/azure-cli-dev-tools/blob/4dd3939b84ab0b7f744837d1e6bab3776731cbbb/azdev/operations/command_change/custom.py#L176), therefore this issue is fixed.