Bump Pylint to 2.17

.pylintrc

@@ -10,7 +10,8 @@ disable=
     too-few-public-methods,
     too-many-arguments,
     consider-using-f-string,
-    unspecified-encoding
+    unspecified-encoding,
+    missing-timeout
 
 [TYPECHECK]
 # For Azure CLI extensions, we ignore some import errors as they'll be available in the environment of the CLI

azdev/operations/help/refdoc/common/directives.py

@@ -53,7 +53,7 @@ class CliGroupDirective(CliBaseDirective):
         Field('docsource', label='Doc Source', has_arg=False,
               names=('docsource', 'documentsource')),
         Field('deprecated', label='Deprecated', has_arg=False,
-              names=('deprecated'))
+              names=('deprecated',))
     ])
 
 
@@ -63,23 +63,23 @@ class CliCommandDirective(CliBaseDirective):
         Field('docsource', label='Doc Source', has_arg=False,
               names=('docsource', 'documentsource')),
         Field('deprecated', label='Deprecated', has_arg=False,
-              names=('deprecated'))
+              names=('deprecated',))
     ])
 
 
 class CliArgumentDirective(CliBaseDirective):
     doc_field_types = copy.copy(_CLI_FIELD_TYPES)
     doc_field_types.extend([
         Field('required', label='Required', has_arg=False,
-              names=('required')),
+              names=('required',)),
         Field('values', label='Allowed values', has_arg=False,
               names=('values', 'choices', 'options')),
         Field('default', label='Default value', has_arg=False,
-              names=('default')),
+              names=('default',)),
         Field('source', label='Values from', has_arg=False,
               names=('source', 'sources')),
         Field('deprecated', label='Deprecated', has_arg=False,
-              names=('deprecated'))
+              names=('deprecated',))
     ])
 
 

azdev/operations/performance.py

@@ -237,7 +237,7 @@ def _benchmark_cmd_staticstic(time_series: list):
     avg_time = sum(time_series) / size
 
     std_deviation = sqrt(
-        sum([(t - avg_time) * (t - avg_time) for t in time_series]) / size
+        sum((t - avg_time) * (t - avg_time) for t in time_series) / size
     )
 
     return {

azdev/operations/tests/test_benchmark.py

@@ -25,7 +25,7 @@ def test_statistic_ok(self):
         max_num = round(rands[-1], 4)
         min_num = round(rands[0], 4)
         avg_num = round(sum(rands) / len(rands), 4)
-        std_num = round(sqrt(sum([(t - avg_num) ** 2 for t in rands]) / len(rands)), 4)
+        std_num = round(sqrt(sum((t - avg_num) ** 2 for t in rands) / len(rands)), 4)
 
         stats = _benchmark_cmd_staticstic(rands)
 

azdev/operations/testtool/tests/test_profile_context.py

@@ -30,4 +30,4 @@ def test_unsupported_profile(self):
     def test_raise_inner_exception(self):
         with self.assertRaises(Exception):
             with ProfileContext('latest'):
-                raise Exception('inner Exception')
+                raise Exception('inner Exception') # pylint: disable=broad-except

setup.py

@@ -70,7 +70,7 @@
         'gitpython',
         'jinja2',
         'knack',
-        'pylint==2.11.1',
+        'pylint==2.16.1',
         'pytest-xdist',  # depends on pytest-forked
         'pytest-forked',
         'pytest>=5.0.0',

tox.ini

@@ -13,5 +13,5 @@ whitelist_externals =
 commands=
     python ./scripts/license_verify.py
     python setup.py check -r -s
-    pylint azdev --rcfile=.pylintrc -r n
+    pylint azdev --rcfile=.pylintrc -r n --load-plugins=pylint.extensions.no_self_use
     flake8 --statistics --append-config=.flake8 azdev