Skip to content

Pin isort and revert pylint #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Jul 8, 2020
Merged

Pin isort and revert pylint #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
809c6e8
Pin isort and revert pylint
jiasli Jul 8, 2020
807d401
update
jiasli Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,11 @@
'tox',
'wheel==0.30.0',
'azure-storage-blob>=1.3.1,<2.0.0',
'isort==4.3.21'
],
extras_require={
":python_version<'3.0'": ['pylint==1.9.2', 'futures'],
":python_version>='3.0'": ['pylint==2.5.3']
":python_version>='3.0'": ['pylint==2.3.0']
Copy link
Contributor

@mmyyrroonn mmyyrroonn Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to release new azdev since the released version is also broken?

Copy link
Member Author

@jiasli jiasli Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily we currently use the main branch of azdev in Azure CLI CI so the fix will applied. But yes, we do need to release a new version of azdev.

Copy link
Collaborator

@yonzhan yonzhan Jul 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version pin issue may exist in other third-party packages, we should look through and pin all of them.

},
package_data={
'azdev.config': ['*.*', 'cli_pylintrc', 'ext_pylintrc'],
Expand Down