-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a devcontainer #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍
@magodo Thank you for your review. I commented and pushed some commits. 😄 |
…created." This reverts commit dfe02b2.
…stCreateCommand' is not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your review and your time 😄 |
Why
ref https://microsoft.github.io/code-with-engineering-playbook/developer-experience/devcontainers/
I would like to make more people can contribute to Azure Terrafy.
I want to use a devcontainer to improve two things. ref https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/introduction-to-dev-containers
What
Set up devcontainer
CONTRIBUTING.md
is not in this repository right now, but I would like to describe how to contribute as follows.How to make the development environment using devcontainer
Using Visual Studio Code with Remote - Containers extension installed, you quickly have your environment set up and ready to go with everything you need to get started.
Open this project in VS Code.
If Docker isn't already running, make sure it is now.
Open the Command Pallet (
Command+Shift+P
on MacOS orCTRL+Shift+P
on Windows). TypeRemote-Containers: Open Folder in Container...
and hit enter. Or click on the remote container icon in the lower-left corner.VS Code will relaunch and begin building your development container. VS Code will install all the necessary dependencies required for you to begin developing.
The container has finished building, open a new terminal in VS Code (
Control+Shift+`
) and type:you can now start developing within the Remote Container environment!