Merging MetaRes and MetaGroup to one
#243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the
MetaResandMetaGroupto one interfaceMeta, which has 4 implementers mapping to the 4 subcommands. TheMetais then shared by one process for interactive and one process for non-interactive mode. Previously, the interactive/non-interactive processes have two implementations for the group (corresponds to rg, query, map modes) and resource mode, where each one has a big part of duplicated code.The benefit of this PR is:
resourcemode now also has interactive mode, which is useful for Azure resource that maps to more than one TF resource