Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Key Vault nested items #104

Merged
merged 3 commits into from
May 23, 2022
Merged

Support Key Vault nested items #104

merged 3 commits into from
May 23, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented May 20, 2022 •
edited
Loading

Fix #86

magodo added 2 commits May 20, 2022 19:35
@magodo
Support Key Vault nested items
fd9d54f 
The generated config for certificate can't pass validation, this needs
to be fixed by the `tfadd`.

Test needed.
@magodo
Update tfadd to v0.7.0 to handle AtLeastOneOf
5c924f4
@magodo magodo marked this pull request as ready for review May 21, 2022 03:53
@magodo magodo requested a review from ms-henglu May 21, 2022 03:53
ms-henglu
ms-henglu approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@ms-henglu ms-henglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍶

@magodo magodo merged commit 730febf into Azure:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms-henglu ms-henglu ms-henglu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Parsing Keyvault Nested Item
2 participants
@magodo @ms-henglu