Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Azure Cosmos DB for NoSQL quickstarts #452

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

seesharprun
Copy link
Contributor

@seesharprun seesharprun commented Oct 17, 2024

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here:

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/static/templates.json that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

  • If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@seesharprun
Copy link
Contributor Author

seesharprun commented Oct 17, 2024

@seesharprun
Copy link
Contributor Author

This is an older template, so there's no need to add the new tag.

@seesharprun
Copy link
Contributor Author

It seems like go wasn't in the list of valid tags.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-xuto Could you test these templates?

@seesharprun We consider "new" tags for templates that are first time added to the awesome-azd .

website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
website/static/templates.json Outdated Show resolved Hide resolved
@seesharprun
Copy link
Contributor Author

@hemarina, I committed your suggestion

@v-xuto
Copy link
Member

v-xuto commented Oct 21, 2024

@v-xuto Could you test these templates?

Testing.

@seesharprun
Copy link
Contributor Author

Thanks for the review. I'll take some time to work on these as some of them are due to a transient issue we're seeing with WebSockets. I'll leave this PR dormant until all those issues are addressed.

The "low hanging fruit" of updating the readme will be done sooner.

@seesharprun
Copy link
Contributor Author

@v-xuto, I updated the templates and closed the GitHub issues. You can retest whenever you are ready.

@v-xuto
Copy link
Member

v-xuto commented Oct 23, 2024

@v-xuto, I updated the templates and closed the GitHub issues. You can retest whenever you are ready.

@seesharprun We have retested these issues, the following are their latest status:

In addition, during the retesting process, a new issue was found due to the update of the readme, please review.

@seesharprun
Copy link
Contributor Author

@v-xuto, I believe I have fixed the three listed bugs. I validated multiple times using my local environment and a GitHub pipeline.

🤞

@v-xuto
Copy link
Member

v-xuto commented Oct 24, 2024

@v-xuto, I believe I have fixed the three listed bugs. I validated multiple times using my local environment and a GitHub pipeline.

🤞

@seesharprun These 3 issues (Issue#49, Issue#19, Issue#55) have been verified and have been fixed.

@hemarina All issues have been fixed. There are currently no issues with this template. Please review.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for your contributions!

@hemarina hemarina merged commit b558b69 into Azure:main Oct 24, 2024
2 checks passed
@seesharprun seesharprun deleted the cosmos-db-nosql-quickstarts branch October 24, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New azd-template] azure-cosmos-db-nosql-*-quickstart
3 participants