-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Azure Cosmos DB for NoSQL quickstarts #452
Conversation
This is an older template, so there's no need to add the |
It seems like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-xuto Could you test these templates?
@seesharprun We consider "new" tags for templates that are first time added to the awesome-azd .
Co-authored-by: hemarina <[email protected]>
@hemarina, I committed your suggestion |
Testing. |
@hemarina, @seesharprun We have finished this template test, and we filed five issues. Please review.
|
Thanks for the review. I'll take some time to work on these as some of them are due to a transient issue we're seeing with WebSockets. I'll leave this PR dormant until all those issues are addressed. The "low hanging fruit" of updating the readme will be done sooner. |
@v-xuto, I updated the templates and closed the GitHub issues. You can retest whenever you are ready. |
@seesharprun We have retested these issues, the following are their latest status:
In addition, during the retesting process, a new issue was found due to the update of the readme, please review. |
@v-xuto, I believe I have fixed the three listed bugs. I validated multiple times using my local environment and a GitHub pipeline. 🤞 |
@seesharprun These 3 issues (Issue#49, Issue#19, Issue#55) have been verified and have been fixed. @hemarina All issues have been fixed. There are currently no issues with this template. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you for your contributions!
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
Your template repository
Place your template repository link here:
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/static/templates.json that includes:
Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")
Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.
Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the
website/src/data/images/
.Link to Author's GitHub or other relevant website - Used for attribution
Author's Name - Name to credit on the gallery card
Link to template source - Link to the template GitHub repo
Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:
"msft"
) or Community-authored ("community"
)"bicep"
or"terraform"
)"new"
tag for any newly authored templatesIn the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.If the template is Microsoft-authored, we encourage you to also publish it to learn.microsoft.com/samples.
If you are submitting a resource to be added to the awesome-azd README: