Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Django to frameworks #203

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Move Django to frameworks #203

merged 1 commit into from
Oct 5, 2023

Conversation

pamelafox
Copy link
Member

I was surprised to see Django listed as a language, since I consider it a Framework. This moves it and changes its category.

I similarly think of React.JS as being a framework, but I guess there's a way in which it's a language.

hemarina
hemarina approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving it to frameworks Pamela. Rethinking about React.JS, it doesn't fall into framework or language as it's a JavaScript library. I should move it to Tools.

@hemarina hemarina merged commit b1765c3 into Azure:main Oct 5, 2023
2 checks passed
@pamelafox
Copy link
Member Author

That makes sense re React

hemarina added a commit that referenced this pull request Oct 19, 2023
@hemarina @rajeshkamal5050 @pamelafox
update filter top and empty search page (#227)
cfbd128 
* rename svg to fix icon not showing issue

* fix search icon (#202)

fix search icon

* remove cosmos tag on azure-search-openai-demo-csharp(#204)

remove cosmos tag on azure-search-openai-demo-csharp

* Move Django to frameworks (#203)

Move Django tag to frameworks

* add font fallback and move reactjs to tools (#205)

Add fallback font family Courier New, Courier, monospace in case Consolas is not rendered

* Fix bug of showing the wrong template card header logo and title website after filtered and closed contribution card (#206)

fix bug with unique key in loops

* update submit template link to contribute page (#209)

update contribute link

* Squashed commit of the following:

commit b838abc
Author: hemarina <[email protected]>
Date:   Tue Oct 10 13:50:08 2023 -0700

    add underline when page is selected

commit 239bd8f
Author: hemarina <[email protected]>
Date:   Mon Oct 9 16:18:48 2023 -0700

    custom navbar

* add filter top bar

* test card sorted

* update div css

* debug filter top bar

* add empty search page

* cleaner timer

* add condition for filter

---------

Co-authored-by: Rajesh Kamal <[email protected]>
Co-authored-by: Pamela Fox <[email protected]>
hemarina added a commit that referenced this pull request Oct 20, 2023
@hemarina
Update navbar (#211)
6801ae4 
* rename svg to fix icon not showing issue

* fix search icon (#202)

* remove cosmos tag on azure-search-openai-demo-csharp(#204)

* Move Django to frameworks (#203)

* add font fallback and move reactjs to tools (#205)

* custom navbar

* add underline when page is selected

* remove templates page

* remove hover color on title

* switch order

* Keep templates bar

* not having templates page for now
hemarina added a commit that referenced this pull request Oct 23, 2023
@hemarina @vhvb1989
Split index.tsx into multiple sub folder (#231)
8d48d26 
* rename svg to fix icon not showing issue

* fix search icon (#202)

* remove cosmos tag on azure-search-openai-demo-csharp(#204)

* Move Django to frameworks (#203)

* add font fallback and move reactjs to tools (#205)

* split index.tsx

* split multiple authors

* finish split index.tsx into sub folders

* fix InputValue

* remove un-used translation

* wip

* Add Render with source to avoid duplicated logic and use key for the fragment that wraps card and contribution

* update copyright on spilt branch

* clean comment

* no need for render

* fix error contribution card disappear

---------

Co-authored-by: Victor Vazquez <[email protected]>
hemarina added a commit that referenced this pull request Oct 27, 2023
@hemarina
update azure icons on card panel (#229)
3ef9234 
* rename svg to fix icon not showing issue

* fix search icon (#202)

* remove cosmos tag on azure-search-openai-demo-csharp(#204)

* Move Django to frameworks (#203)

* add font fallback and move reactjs to tools (#205)

* Squashed commit of the following:

* add azure service icon, minor tweaks

* fix warning error message

* fix error

* update style

* fix error and update purple color

* update fontfamily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemarina hemarina hemarina approved these changes

@gkulin gkulin Awaiting requested review from gkulin gkulin is a code owner

@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050 rajeshkamal5050 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pamelafox @hemarina