-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open ai with Locked down bot azd template #168
Open ai with Locked down bot azd template #168
Conversation
Sure. We will start testing this template today. |
@hemarina We have finished the template test, and we have filed two issues. Please review. |
@v-xuto - should be good to test again. I've updated my repo's readme.md file to show the various ways to use this template (controlled by azd env variables). |
…late/openai-azure-enterprise-chatbot
@graemefoster We have retested this template, we found one new issue. Please help review and resolve. |
…late/openai-azure-enterprise-chatbot
Thanks @v-xuto . This looks like a capacity problem on your subscription rather than a template problem so I don't think I can do anything to help here.... See Azure-Samples/azure-search-openai-demo#313 for a similar problem. I've lowered the default capacity on mine to 20, but have you purged the other OpenAI services you've created from other templates? FWIW this one (https://github.com/pascalvanderheiden/ais-apim-openai) just got approved with pretty much the same bicep mine has. Hopefully this helps you get mine merged in. |
@graemefoster For graemefoster/LockedDownChatBot#3, I had added new comments. |
Thanks @v-xuto. I've pushed a new version that allows you to specify OpenAi location using the env var "OPENAI_LOCATION", and added doco for it. I've kept the default as 'eastus'. Problem I have is that OpenAI isn't available in most locations, so I have to choose a default at the very least. When I deploy I default to australiaeast which doesn't have OpenAi, but if you default to eastus2 then you might be letting templates through that will break for OpenAi in locations that don't have it. Thanks, Graeme |
@hemarina Issue graemefoster/LockedDownChatBot#3 has been fixed, currently this template has no issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CC @jongio in case for more suggestions on repro or bicep files.
Not required, but it would be great if you could use the azd core infra that we use in other azd templates. There's some good modules and code in yours that would be good to share with other azd users as well. You could replace a lot of the bicep code in your template as well. You can find them here: https://github.com/Azure/azure-dev/tree/main/templates/common/infra/bicep |
In order for a user to use an existing resource in a different location you'll need to expose a location param for each resource group. You can see how we do that in this template here: https://github.com/Azure-Samples/azure-search-openai-demo-csharp/blob/main/infra/main.bicep#L37 |
Are you sure about this @jongio? The template as-is works fine with an existing OpenAI in a different resource-group / location and BIcep doesn't allow you to provide a 'location' when the resource is marked as existing. Whilst developing I had all new resources in AU-East, and OpenAI in EastUS. The template allows you to override the eastus location using the openAiLocation parameter. (The template you linked to doesn't reference an existing resource - it creates a new one in a different location.) |
I'll see what I can re-use. Would be great to package these into a container so we could reference them. They look to change quite often. |
This might take a bit more time... Unfortunately what Bicep gives with one hand, it takes with the other... As an example, I tried an easy one and found that my RBAC would need to move either into the OpenAI module (complicating it), or into another module. I then have to pass loosey-goosey object arrays around and lose all type safety making the Bicep hard to debug... I'd use strong-typing but I've had issues before with it, and I think it is still in preview. :( |
Okay, you are right, it looks like location isn't required when you reference an existing resource, but is when you add a resource to an existing resource group. Yes, the modules will be in a registry soon. Tracked: Azure/azure-dev#751 What I suggest is that we get this in awesome-azd as-is and then we can integrate modules later. |
…late/openai-azure-enterprise-chatbot
Thank you all for cooperating and getting this template added to the gallery. I'll merge it. Let me know if there're any questions or concerns. |
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
website/src/data/images/
.In the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.If you are submitting a resource to be added to the awesome-azd README: