Skip to content

fix async patch and post LRO #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 30, 2016
Merged

fix async patch and post LRO #875

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f058543
fix async patch and post run
Mar 22, 2016
b789377
add test for fixing the post/patch async operation
Mar 23, 2016
9c7e28b
code revise
Mar 24, 2016
6e478d4
fix async patch and post run
Mar 22, 2016
f72ae19
Merge branch 'master' of https://github.com/csmengwan/autorest
Mar 24, 2016
4ab8892
style change
Mar 24, 2016
39b4b19
code revise
Apr 6, 2016
d1ff941
fix the naming issue in azure serviceClientTest
Apr 6, 2016
9573dee
code revise
Apr 6, 2016
b9d642d
add 204 poll state for post
Apr 7, 2016
5b4ca29
change code gen in node js to merge LRO operations into one method
Apr 7, 2016
46b1540
Merge branch 'master' of https://github.com/Azure/autorest
Apr 26, 2016
2f7d3e4
Deprecate two old functions
Apr 27, 2016
1a6bf4e
code revise
Apr 27, 2016
340132b
Merge branch 'master' of https://github.com/Azure/autorest
Apr 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...Generators/NodeJS/Azure.NodeJS.Tests/Expected/AcceptanceTests/Lro/operations/lRORetrys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ LRORetrys.prototype.put201CreatingSucceeded200 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -334,7 +334,7 @@ LRORetrys.prototype.putAsyncRelativeRetrySucceeded = function (options, callback
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -562,7 +562,7 @@ LRORetrys.prototype.deleteProvisioning202Accepted200Succeeded = function (option
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -782,7 +782,7 @@ LRORetrys.prototype.delete202Retry200 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -952,7 +952,7 @@ LRORetrys.prototype.deleteAsyncRelativeRetrySucceeded = function (options, callb
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1130,7 +1130,7 @@ LRORetrys.prototype.post202Retry200 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1332,7 +1332,7 @@ LRORetrys.prototype.postAsyncRelativeRetrySucceeded = function (options, callbac
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down
50 changes: 25 additions & 25 deletions ...t/Generators/NodeJS/Azure.NodeJS.Tests/Expected/AcceptanceTests/Lro/operations/lROSADs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ LROSADs.prototype.putNonRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -326,7 +326,7 @@ LROSADs.prototype.putNonRetry201Creating400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -576,7 +576,7 @@ LROSADs.prototype.putAsyncRelativeRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -799,7 +799,7 @@ LROSADs.prototype.deleteNonRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -965,7 +965,7 @@ LROSADs.prototype.delete202NonRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1133,7 +1133,7 @@ LROSADs.prototype.deleteAsyncRelativeRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1309,7 +1309,7 @@ LROSADs.prototype.postNonRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1506,7 +1506,7 @@ LROSADs.prototype.post202NonRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1705,7 +1705,7 @@ LROSADs.prototype.postAsyncRelativeRetry400 = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -1906,7 +1906,7 @@ LROSADs.prototype.putError201NoProvisioningStatePayload = function (options, cal
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -2156,7 +2156,7 @@ LROSADs.prototype.putAsyncRelativeRetryNoStatus = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -2390,7 +2390,7 @@ LROSADs.prototype.putAsyncRelativeRetryNoStatusPayload = function (options, call
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -2614,7 +2614,7 @@ LROSADs.prototype.delete204Succeeded = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -2783,7 +2783,7 @@ LROSADs.prototype.deleteAsyncRelativeRetryNoStatus = function (options, callback
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -2960,7 +2960,7 @@ LROSADs.prototype.post202NoLocation = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -3160,7 +3160,7 @@ LROSADs.prototype.postAsyncRelativeRetryNoPayload = function (options, callback)
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -3361,7 +3361,7 @@ LROSADs.prototype.put200InvalidJson = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -3594,7 +3594,7 @@ LROSADs.prototype.putAsyncRelativeRetryInvalidHeader = function (options, callba
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -3828,7 +3828,7 @@ LROSADs.prototype.putAsyncRelativeRetryInvalidJsonPolling = function (options, c
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPutOrPatchOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4052,7 +4052,7 @@ LROSADs.prototype.delete202RetryInvalidHeader = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4220,7 +4220,7 @@ LROSADs.prototype.deleteAsyncRelativeRetryInvalidHeader = function (options, cal
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4389,7 +4389,7 @@ LROSADs.prototype.deleteAsyncRelativeRetryInvalidJsonPolling = function (options
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4566,7 +4566,7 @@ LROSADs.prototype.post202RetryInvalidHeader = function (options, callback) {
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4766,7 +4766,7 @@ LROSADs.prototype.postAsyncRelativeRetryInvalidHeader = function (options, callb
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down Expand Up @@ -4967,7 +4967,7 @@ LROSADs.prototype.postAsyncRelativeRetryInvalidJsonPolling = function (options,
initialResult.request = httpRequest;
initialResult.response = response;
initialResult.body = response.body;
client.getPostOrDeleteOperationResult(initialResult, options, function (err, pollingResult) {
client.getLongRunningOperationResult(initialResult, options, function (err, pollingResult) {
if (err) return callback(err);

// Create Result
Expand Down
Loading