-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenAPI to TypeSpec] - Support primitive types as array elements #4738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
force-pushed
the
openaitotsp-may-update
branch
from
May 23, 2023 23:45
46feb6c
to
b95f6e3
Compare
packages/extensions/openapi-to-cadl/src/transforms/transform-object.ts
Outdated
Show resolved
Hide resolved
You may test this build by running Add the following CLI flags
Or with all autorest --version:https://tinyurl.com/2gyrqdp6 --use:https://tinyurl.com/2p6l9bph or use the following in your autorest configuration: # For changes to autorest core
version: "https://tinyurl.com/2gyrqdp6"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "https://tinyurl.com/2p6l9bph" If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
packages/extensions/openapi-to-cadl/src/emiters/emit-cadl-config.ts
Outdated
Show resolved
Hide resolved
packages/extensions/openapi-to-cadl/test/analyzeText/tsp-output/package.json
Show resolved
Hide resolved
You may test this build by running Add the following CLI flags
Or with all autorest --version:https://tinyurl.com/2kujmnn9 --use:https://tinyurl.com/2ze9fc86 or use the following in your autorest configuration: # For changes to autorest core
version: "https://tinyurl.com/2kujmnn9"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "https://tinyurl.com/2ze9fc86" If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
You may test this build by running Add the following CLI flags
Or with all autorest --version:https://tinyurl.com/2qx54h5p --use:https://tinyurl.com/2pcj2mzg or use the following in your autorest configuration: # For changes to autorest core
version: "https://tinyurl.com/2qx54h5p"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "https://tinyurl.com/2pcj2mzg" If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
joheredi
force-pushed
the
openaitotsp-may-update
branch
from
May 26, 2023 14:37
31faa3f
to
b0f57b4
Compare
You may test this build by running Add the following CLI flags
Or with all autorest --version:https://tinyurl.com/2l9dlf6t --use:https://tinyurl.com/2pejmnay or use the following in your autorest configuration: # For changes to autorest core
version: "https://tinyurl.com/2l9dlf6t"
# For changes to modelerfour
use-extension:
"@autorest/modelerfour": "https://tinyurl.com/2pejmnay" If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it. |
timotheeguerin
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had limited the support of array elements to Model, however we should also support primitive types.
We are also updating so that it generates TypeSpec compatible with compiler version 0.44.0