Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI to TypeSpec] - Support primitive types as array elements #4738

Merged
merged 5 commits into from
May 26, 2023

Conversation

joheredi
Copy link
Member

We had limited the support of array elements to Model, however we should also support primitive types.

We are also updating so that it generates TypeSpec compatible with compiler version 0.44.0

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2gyrqdp6 For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/2p6l9bph For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2gyrqdp6 --use:https://tinyurl.com/2p6l9bph

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2gyrqdp6"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/2p6l9bph"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2kujmnn9 For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/2ze9fc86 For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2kujmnn9 --use:https://tinyurl.com/2ze9fc86

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2kujmnn9"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/2ze9fc86"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2qx54h5p For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/2pcj2mzg For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2qx54h5p --use:https://tinyurl.com/2pcj2mzg

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2qx54h5p"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/2pcj2mzg"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@azure-pipelines
Copy link

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2l9dlf6t For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/2pejmnay For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2l9dlf6t --use:https://tinyurl.com/2pejmnay

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2l9dlf6t"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/2pejmnay"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@timotheeguerin timotheeguerin merged commit 0354d7f into main May 26, 2023
@timotheeguerin timotheeguerin deleted the openaitotsp-may-update branch May 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants