Skip to content

Adding ReadablePath property for redable output paths#1779

Merged
vishrutshah merged 4 commits intoAzure:masterfrom
vishrutshah:remove_sanitization
Feb 3, 2017
Merged

Adding ReadablePath property for redable output paths#1779
vishrutshah merged 4 commits intoAzure:masterfrom
vishrutshah:remove_sanitization

Conversation

@vishrutshah
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah commented Feb 2, 2017

New Output:

vishrut@mac autorest (master) $ mono src/core/AutoRest/bin/Debug/net451/osx.10.12-x64/AutoRest.exe -CodeGenerator None -I https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-cdn/2016-10-02/swagger/cdn.json
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/endpoints/{endpointName}/start/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/endpoints/{endpointName}/stop/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/endpoints/{endpointName}/purge/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Cdn/profiles/{profileName}/endpoints/{endpointName}/load/post/Extensions/x-ms-long-running-operation

Old Output:

vishrut@mac autorest (master) $ mono src/core/AutoRest/bin/Debug/net451/osx.10.12-x64/AutoRest.exe -CodeGenerator None -I https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-cdn/2016-10-02/swagger/cdn.json
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Cdn~1profiles~1{profileName}~1endpoints~1{endpointName}~1start/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Cdn~1profiles~1{profileName}~1endpoints~1{endpointName}~1stop/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Cdn~1profiles~1{profileName}~1endpoints~1{endpointName}~1purge/post/Extensions/x-ms-long-running-operation
WARNING: LongRunningResponseValidation - An operation with x-ms-long-running-operation extension must have a valid terminal success status code. 200 or 201 for Put/Patch. 200, 201 or 204 for Post. 200 or 204 or both for Delete.
	Path: #/Paths/~1subscriptions~1{subscriptionId}~1resourceGroups~1{resourceGroupName}~1providers~1Microsoft.Cdn~1profiles~1{profileName}~1endpoints~1{endpointName}~1load/post/Extensions/x-ms-long-running-operation

@veronicagg @olydis @sarangan12 Feel free to review the PR when you get a chance. Thanks !

@vishrutshah
Copy link
Copy Markdown
Contributor Author

@olydis Seems like I am breaking SwaggerModelerCompareTests with this change. Could you please help me understand why are we using sanitization and whether there is some other solution to keep the output readable or should I just update tests?

@vishrutshah vishrutshah self-assigned this Feb 2, 2017
Copy link
Copy Markdown
Contributor

@olydis olydis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vishrutshah
Copy link
Copy Markdown
Contributor Author

@olydis Thanks for the review!!

@vishrutshah vishrutshah changed the title Removing sanitization for redable output paths Adding ReadablePath property for redable output paths Feb 3, 2017
@vishrutshah vishrutshah merged commit 019e58f into Azure:master Feb 3, 2017
@vishrutshah vishrutshah deleted the remove_sanitization branch February 3, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants