Skip to content

Conversation

@vishrutshah
Copy link
Contributor

@azurecla
Copy link

Hi @vishrutshah, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

attr_accessor :tags

# @return [String] the kind of the resource.
# FIXME kind attribute was introduced because of SiteInstance model of azure_mgmt_web gem has kind attribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 'kind' becomes part of resource, we may not need a 'fixme' comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veronicagg I completely agree but i haven't found any swagger other than web doing this, so i was thinking to keep it until 'kind' officially becomes part of all resource.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind is in this storage spec. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devigned I see the "kind" but it is not part of the Resource definition. azure_arm_web is adding "kind" in the resource itself. Isn't that different?

@veronicagg
Copy link
Contributor

@vishrutshah left one comment, change looks good to me, thanks!

@vishrutshah
Copy link
Contributor Author

@veronicagg @devigned Thanks for the feedback. Closing this PR with respect to #1263 that'll avoid failures on unknown properties of the object while serializing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants