Skip to content

Fix the import ordering in-consistent issues #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaryGao wants to merge 1 commit into from
Closed

Fix the import ordering in-consistent issues #3382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/typespec-ts/src/framework/hooks/binder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,10 @@ class BinderImp implements Binder {
this.resolveDependencyReferences(file);
const importStructures = this.imports.get(file);
if (importStructures) {
// Sort imports in place by module specifier to ensure consistent ordering
importStructures.sort((a, b) =>
a.moduleSpecifier < b.moduleSpecifier ? -1 : 1
);
for (const importStructure of importStructures) {
file.addImportDeclaration(importStructure);
}
Expand Down
Loading