-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New spread support #2653
Merged
Merged
New spread support #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
commented
Jul 10, 2024
packages/typespec-test/test/chatApi_modular/generated/typespec-ts/src/rest/clientDefinitions.ts
Show resolved
Hide resolved
qiaozha
commented
Jul 10, 2024
packages/typespec-test/test/eventgrid_modular/generated/typespec-ts/review/eventgrid.api.md
Show resolved
Hide resolved
qiaozha
commented
Jul 10, 2024
packages/typespec-test/test/widget_dpg/generated/typespec-ts/src/classic/widgets/index.ts
Show resolved
Hide resolved
qiaozha
commented
Jul 11, 2024
qiaozha
commented
Jul 11, 2024
MaryGao
reviewed
Jul 12, 2024
joheredi
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this fix to unblock moving the latest TCGC. In the meantime I'll setup some infrastructure so that we can move to using TCGC types in a more organized and smooth way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2414
In typespec, we have two kinds of spread.
Previously, we have decided that we will treat spread of a alias as a payload flatten in this pr #2020 (comment) and spread of a model is not a payload flatten.
With payload flatten, the method signature would look like
Without payload flatten, the method signature would be:
And because alias was treated as anonymous model, we used to call
getEffectivePayloadType
from typespec compiler to try to get a valid payload type whenever possible, our previous spread condition becomes we flatten payload for anonymous model. it has a potential draw back which is we don't know if this model is defined as anonymous or become anonymous because of alias spread.In Azure/typespec-azure#1043, we found that this kind of difference is too complex for customer to understand the client side behavior differently per on model or alias. we have decided to change that spread of a model is also a payload flatten.
In this PR, we have
now spread is spread, anonymous model is anonymous model.