-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support void type in RLC and Modular #2521
Conversation
assert.fail("Should throw diagnostic errors"); | ||
} catch (e: any) { | ||
assert.equal(e[0]?.code, "@azure-tools/typespec-ts/invalid-schema"); | ||
assert.equal(e[0]?.message, "Couldn't get schema for type Intrinsic"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this error message be more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are type relevant info actually and i could add the assertion here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l leverage the existing rule invalid-schema
for this check and let me know if you think we need a new linter for void.
fixes #2492