-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues in todo: anonymous array model import and sample mock value for credential #2342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and just small comments.
} else { | ||
clientParams.push({ | ||
name: "credential", | ||
assignment: `const credential = {getToken: () => Promise.resolve({ token: "{Your token}", expiresOnTimestamp: 0 })};` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joheredi I wonder if you have any concerns for this part for generating the mock value for token credential as we don't have @azure/identity
in non-branded scope.
) { | ||
clientParams.push({ | ||
name: "credential", | ||
assignment: `const credential = { key: "{Your API key}"};` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also for the KeyCredential mock value here.
I will merge it for now, @joheredi let me know if you have any concerns. |
fixes #2326
fixes #2330