Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change branded setting to "flavor" #2332

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Conversation

timovv
Copy link
Member

@timovv timovv commented Mar 4, 2024

Fixes #2324

  • Add new option flavor. When set to Azure, an SDK using Azure Core will be generated.
    • flavor defaults to Azure if the package scope starts with azure or msinternal (for tests). Eventually maybe we should make our tests emit unflavored code by default and only select Azure flavor where necessary.
    • For backward compat, if branded is set to true and flavor is left unset, flavor will be set to Azure.
    • Otherwise, if flavor is unset, or is set to any other value, an unbranded package will be generated.

@timovv timovv marked this pull request as ready for review March 4, 2024 23:14
Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking this work! 🚢

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I approved and just left small comments.

@timovv timovv merged commit dd3484c into Azure:main Mar 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default generation flavor and flags for generic codegen
3 participants