Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the version of typespec #2286

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Feb 7, 2024

update the typespec compiler version to 0.53

@qiaozha qiaozha marked this pull request as ready for review February 21, 2024 05:06
| Uint8Array
| ReadableStream<Uint8Array>
| NodeJS.ReadableStream;
file: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help to explain why we change this?

Copy link
Member

@qiaozha qiaozha Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RLC layer, we only generate

string
  | Uint8Array
  | ReadableStream<Uint8Array>
  | NodeJS.ReadableStream;

for binary bytes, if it's other encoded bytes, we will just treat it as normal string, because of the tcgc lint rule for bytes in multipart/form-data request, we have to remove the encode decorator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the right solution for RLC here is to figure out a way to suppress the linter rule in TCGC, instead of changing the typespec ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will come back to be a File with Mary's PR, is that correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @MaryGao can you help verify if your calculation will not rely on any encode information on bytes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiaozha qiaozha merged commit 7ab1879 into Azure:main Feb 22, 2024
28 checks passed
@kazrael2119 kazrael2119 deleted the upgrade-typescpec-version branch February 22, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants