-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade the version of typespec #2286
Conversation
.../typespec-test/test/openai_generic/generated/typespec-ts/src/api/audio/translations/index.ts
Show resolved
Hide resolved
packages/typespec-test/test/openai_modular/generated/typespec-ts/review/openai_modular.api.md
Show resolved
Hide resolved
| Uint8Array | ||
| ReadableStream<Uint8Array> | ||
| NodeJS.ReadableStream; | ||
file: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help to explain why we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RLC layer, we only generate
string
| Uint8Array
| ReadableStream<Uint8Array>
| NodeJS.ReadableStream;
for binary bytes, if it's other encoded bytes, we will just treat it as normal string, because of the tcgc lint rule for bytes in multipart/form-data request, we have to remove the encode decorator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the right solution for RLC here is to figure out a way to suppress the linter rule in TCGC, instead of changing the typespec ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will come back to be a File with Mary's PR, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, @MaryGao can you help verify if your calculation will not rely on any encode information on bytes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the typespec compiler version to 0.53