Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modular] Add the optional body case in cadl-ranch #2238

Merged
merged 19 commits into from
Mar 7, 2024

Conversation

MaryGao
Copy link
Contributor

@MaryGao MaryGao commented Jan 24, 2024

fixes #2208
[modular] Add the optional body case in cadl-ranch

.vscode/launch.json Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
@MaryGao MaryGao marked this pull request as ready for review March 6, 2024 07:30
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we really don't have ut that could reflect the change?

@MaryGao
Copy link
Contributor Author

MaryGao commented Mar 7, 2024

LGTM, but we really don't have ut that could reflect the change?

yeah, I enabled the one I used for debug here. But skipped other nullable cases and it is not supported yet.

I want to support them once the modular refactor is done.

@MaryGao MaryGao merged commit e8c5a03 into Azure:main Mar 7, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body parameter optionality
3 participants