-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade-typespec-compiler-to-0.51.0 #2203
upgrade-typespec-compiler-to-0.51.0 #2203
Conversation
packages/typespec-ts/test/integration/generated/mediaTypes/src/clientDefinitions.ts
Outdated
Show resolved
Hide resolved
.../typespec-ts/test/integration/generated/parameters/body-optionality/src/clientDefinitions.ts
Show resolved
Hide resolved
packages/typespec-ts/test/integration/generated/unions/src/outputModels.ts
Show resolved
Hide resolved
packages/typespec-ts/test/modularIntegration/clientStructureDefault.spec.ts
Show resolved
Hide resolved
...odularIntegration/generated/client/structure/renamed-operation/src/RenamedOperationClient.ts
Outdated
Show resolved
Hide resolved
packages/typespec-ts/test/modularIntegration/generated/parameters/spread/src/models/options.ts
Outdated
Show resolved
Hide resolved
packages/typespec-test/test/openai_generic/generated/typespec-ts/src/index.ts
Show resolved
Hide resolved
packages/typespec-ts/test/integration/generated/projection/src/clientDefinitions.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and just small confirmation.
@@ -9,7 +9,6 @@ options: | |||
azureSdkForJs: false | |||
isTypeSpecTest: true | |||
isModularLibrary: true | |||
hierarchyClient: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to enable the hierarchyClient for client structure related test as tcgc has an issue about indicating whether an interface has an @operationGroup
decorator on it. and previously, we still respect the @operationGroup decorator even if the hierarchyClient is false and enableOperationGroup is not enabled.
@@ -7,4 +7,3 @@ export { | |||
RenamedOperationClientOptions, | |||
ServiceContext, | |||
} from "./RenamedOperationContext.js"; | |||
export { renamedTwo, renamedFour, renamedSix } from "./group/index.js"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is expected as we require customer to access the operation under ./api/group
subpath with hierarchyClient enabled.
No description provided.