Add coverage cases for arrays-item-types in cadl-ranch #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzhxiaofeng
requested review from
sarangan12,
joheredi,
qiaozha and
MaryGao
as code owners
|
@qiaozha When running integration-test, get error as follow: |
MaryGao
reviewed
Jan 24, 2024
qiaozha
reviewed
Jan 25, 2024
qiaozha
reviewed
Jan 25, 2024
| @@ -944,7 +944,7 @@ function deserializeResponseValue( | |||
| type.elementType!, | |||
| "p", | |||
| runtimeImports, | |||
| required, | |||
| true, | |||
There was a problem hiding this comment.
Just found typespec can't not define this way playground link
There was a problem hiding this comment.
I would assume elementTypes are all required, for nullable, since the current nullable logic has problem, I would prefer to have another independent pr to fix it. @MaryGao let me know if you have different thoughts.
|
Add test case , encountered the following error: |
qiaozha
reviewed
Jan 25, 2024
| }, | ||
| { | ||
| type: "datetime", | ||
| defaultValue: [new Date("2022-08-26T18:38:00Z")] |
There was a problem hiding this comment.
Datetime type is a Date typescript type in modular.
Comment on lines
+46
to
+47
| { property: "hello", children: undefined }, | ||
| { property: "world", children: undefined } |
There was a problem hiding this comment.
the children: undefined are added by the current serialization and deserialization logic in modular.
qiaozha
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2215
When generate test SDK for arrays-item-types, it failed and returns an error which is shown as following: