Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sample generation #2099

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix sample generation #2099

merged 2 commits into from
Nov 7, 2023

Conversation

kazrael2119
Copy link
Contributor

fix #2098
Special character can not be generated as a parameter name from sample generation, this pr is to fix this

@kazrael2119 kazrael2119 mentioned this pull request Nov 7, 2023
Closed
@kazrael2119
Copy link
Contributor Author

related sample: https://github.com/Azure/azure-sdk-for-js/pull/27655/files#diff-57333f3ec9d7cf6ea2a6f5ff75e1cb39ed9ade679f7fdeb23d759bc185ca5189R87

MaryGao
MaryGao approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit 5776b14 into Azure:main Nov 7, 2023
28 checks passed
@kazrael2119 kazrael2119 deleted the fix-sample-generation branch November 8, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special character can not be generated as a parameter name from sample generation
2 participants
@kazrael2119 @MaryGao