Fix missing handling of overload in isUnexpected #2097
Conversation
joheredi
requested review from
sarangan12,
qiaozha and
MaryGao
as code owners
| response: PublishCloudEvent200Response | PublishCloudEventDefaultResponse | ||
| response: | ||
| | PublishCloudEvent200Response | ||
| | PublishCloudEvents200Response |
There was a problem hiding this comment.
It seems that we have sharedRoute cases in smoke testing and there is no error reported during npm run build. But the build error is reported in OpenAI.
Do you know what caused the difference? I guess maybe the tsconfig.json is inconsistant.
There was a problem hiding this comment.
Which build error in OpenAI? The one in the issue? I think that was relying on a branch that hasn't made it to main, that's why our smoke-tests are not failing
There was a problem hiding this comment.
Maybe I remembered wrongly and checking here #2013 (comment)
joheredi
force-pushed
the
isunexpected-overloads
branch
from
5e3c347
to
aa0f9f1
Compare
| @@ -105,6 +105,7 @@ import { | |||
| LibraryGetDefaultResponse, | |||
| LibraryCreate200Response, | |||
| LibraryCreate202Response, | |||
| LibraryAppend201Response, | |||
There was a problem hiding this comment.
Why do we have these changes? I don't think we have sharedRoute cases in swagger?
| op getAvatarAsPng is Azure.Core.RpcOperation<PngImage, {@header accept: "image/png"}>; | ||
|
|
||
| @route("/avatar") | ||
| @sharedRoute |
There was a problem hiding this comment.
not a priorty and we have the sharedRoute and overload testing in RLC integration and could we enable them in modular integration?
joheredi
force-pushed
the
isunexpected-overloads
branch
from
673179e
to
18e0ce6
Compare
Is unexpected was missing the return ypes for overloads. Adding them.
Cast cast in Modular to the specific RLC overload
fixes #2013