-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ts http runtime #2083
Conversation
packages/autorest.typescript/src/restLevelClient/transforms/transform.ts
Outdated
Show resolved
Hide resolved
...ges/typespec-ts/test/nonBrandedIntegration/modular/generated/models/usage/src/UsageClient.ts
Outdated
Show resolved
Hide resolved
packages/typespec-ts/test/nonBrandedIntegration/modular/generated/models/usage/tspconfig.yaml
Show resolved
Hide resolved
packages/typespec-test/test/openai_non_branded/generated/typespec-ts/package.json
Outdated
Show resolved
Hide resolved
@@ -11,6 +11,7 @@ import { Client, ModularCodeModel, Operation } from "./modularCodeModel.js"; | |||
import { isRLCMultiEndpoint } from "../utils/clientUtils.js"; | |||
import { getDocsFromDescription } from "./helpers/docsHelpers.js"; | |||
import { SdkContext } from "../utils/interfaces.js"; | |||
import { getImportSpecifier } from "@azure-tools/rlc-common"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It strikes me as odd to see an rlc-common import in the modular codegen layer. Probably okay but wanted to bring this up in case there is an alternative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the rlc-common utils are widely used in modular lib e.g naming utils or rlc operation utils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left a couple of comments, non blocking but would be great if we can address them before merging
fixes #2081
branded
and allow to generate the non-branded SDK