Fix nullable property generation #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
sarangan12,
qiaozha and
MaryGao
as code owners
joheredi
force-pushed
the
fix-nullability
branch
from
866cfcd
to
6e91f86
Compare
qiaozha
reviewed
Oct 22, 2023
| @@ -8,7 +8,7 @@ export interface CloudEvent { | |||
| /** Identifies the context in which an event happened. The combination of id and source must be unique for each distinct event. */ | |||
| source: string; | |||
| /** Event data specific to the event type. */ | |||
| data?: any; | |||
| data?: unknown; | |||
There was a problem hiding this comment.
I remember we treat unknown as any in the RLC output model ? And in Modular, we don't have the output and input models separated, Is it okay to use unknown here ?
There was a problem hiding this comment.
This is a good point, lets park it and have a discussion.
Filed: #2078
packages/typespec-test/test/openai_modular/generated/typespec-ts/src/models/models.ts
Outdated
Show resolved
Hide resolved
qiaozha
reviewed
Oct 22, 2023
qiaozha
reviewed
Oct 22, 2023
qiaozha
reviewed
Oct 23, 2023
MaryGao
reviewed
Oct 23, 2023
MaryGao
reviewed
Oct 23, 2023
MaryGao
reviewed
Oct 23, 2023
MaryGao
approved these changes
Oct 23, 2023
timovv
approved these changes
Oct 23, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been generating incorrect property types when marked as Nullable in TypeSpec. This PR addresses that and also refactors the involved code for improved readability and maintenance